<html>
<head><meta charset="utf-8"><title>Sorry for being absent · clippy · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/index.html">clippy</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html">Sorry for being absent</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="214292079"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214292079" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214292079">(Oct 23 2020 at 09:39)</a>:</h4>
<p>Sorry for being a bit absent recently. I'll start a new job in a new town next month and currently have some real life administrative stuff to do. I still try to get in a round of review once a week.</p>
<p>What also fell under the table yesterday was the biweekly clippy-&gt;rust sync. <span class="user-mention" data-user-id="279272">@Eduardo Broto</span> can you do this? Otherwise I'll try to do it this evening.</p>



<a name="214292494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214292494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eduardo Broto <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214292494">(Oct 23 2020 at 09:44)</a>:</h4>
<p>Of course, I'll take care of it this afternoon</p>



<a name="214313073"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214313073" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eduardo Broto <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214313073">(Oct 23 2020 at 13:29)</a>:</h4>
<p>For some reason bors is ignoring me in the Rustup PR I need to open before syncing <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="214339147"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214339147" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eduardo Broto <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214339147">(Oct 23 2020 at 17:04)</a>:</h4>
<p>It seems it was a general problem with bors. It's fixed now <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span> </p>
<p>I'll finish the sync later.</p>



<a name="214352810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214352810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214352810">(Oct 23 2020 at 18:58)</a>:</h4>
<p><span class="user-mention" data-user-id="279272">@Eduardo Broto</span> you may have to run <code>cargo update -p clippy</code> after the sync and update the <code>Cargo.lock</code> file. Please put the lock file update (if necessary) in a separate commit. The PR should then be accepted with <code>rollup=never</code></p>



<a name="214378650"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214378650" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eduardo Broto <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214378650">(Oct 23 2020 at 22:15)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/78310">#78310</a> (took a while to build <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span>)</p>



<a name="214431241"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214431241" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Takayuki Nakata <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214431241">(Oct 24 2020 at 14:42)</a>:</h4>
<p>If there is anything I can do to help, I'm happy to help.</p>



<a name="214441264"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214441264" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214441264">(Oct 24 2020 at 18:12)</a>:</h4>
<p><span class="user-mention" data-user-id="316507">@Takayuki Nakata</span> issue triage would be really helpful. This mainly includes answering questions, labeling (with @rustbot) and finding duplicate issues. Sometimes it also involves asking questions, like if the OP has a minimal example if not provided or similar.</p>



<a name="214441356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214441356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214441356">(Oct 24 2020 at 18:13)</a>:</h4>
<p>I promise to do a round of review tomorrow. I was pinged twice only today from different PRs.</p>



<a name="214481627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214481627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214481627">(Oct 25 2020 at 10:14)</a>:</h4>
<p>Alright, I'm down to 38 notification, after reviewing all my assigned PRs and PRs I was mentioned in. Since I fully trust the other reviewers, I won't look at PRs I'm not assigned to or (team) mentioned in, in the future. So if you have questions, please ping me.</p>
<p><span class="user-mention" data-user-id="316507">@Takayuki Nakata</span> What's also really helpful is PR triage. So if there is no reaction from the PR author OR PR reviewer for about 2 weeks, comment with <code>Ping from triage @culprit. &lt;Question about the plan on how to move forward&gt;?</code>.</p>



<a name="214488474"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214488474" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Takayuki Nakata <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214488474">(Oct 25 2020 at 13:00)</a>:</h4>
<p>Thanks for your comments! I'll do that.</p>



<a name="214488731"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214488731" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Takayuki Nakata <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214488731">(Oct 25 2020 at 13:06)</a>:</h4>
<p>If the author has not responded to a previous ping and more than 2 weeks have passed with no activity, should I inform someone on the clippy team to close PR. For example, <a href="https://github.com/rust-lang/rust-clippy/pull/5896">https://github.com/rust-lang/rust-clippy/pull/5896</a></p>



<a name="214489398"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214489398" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214489398">(Oct 25 2020 at 13:23)</a>:</h4>
<p>Thanks! Yes, that would be great.</p>



<a name="214493725"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214493725" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Bimo <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214493725">(Oct 25 2020 at 15:01)</a>:</h4>
<p><span class="user-mention silent" data-user-id="264664">Philipp Krones</span> <a href="#narrow/stream/257328-clippy/topic/Sorry.20for.20being.20absent/near/214481627">said</a>:</p>
<blockquote>
<p>Alright, I'm down to 38 notification, after reviewing all my assigned PRs and PRs I was mentioned in. Since I fully trust the other reviewers, I won't look at PRs I'm not assigned to or (team) mentioned in, in the future. So if you have questions, please ping me.</p>
<p><span class="user-mention silent" data-user-id="316507">Takayuki Nakata</span> What's also really helpful is PR triage. So if there is no reaction from the PR author OR PR reviewer for about 2 weeks, comment with <code>Ping from triage @culprit. &lt;Question about the plan on how to move forward&gt;?</code>.</p>
</blockquote>
<p>Hi <span class="user-mention" data-user-id="264664">@Philipp Krones</span> , do you still need another help for PR triage?  i can help if its only requires pair of eyes</p>



<a name="214493854"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214493854" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214493854">(Oct 25 2020 at 15:03)</a>:</h4>
<p>PR and issue triage would be really helpful, more eyes means less work for each person. PR triage is easier, since it requires only pinging the author/reviewer. Issue triage also requires some knowledge of Clippy to answer questions or write short mentoring instructions (or labeling issues).</p>



<a name="214494030"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214494030" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214494030">(Oct 25 2020 at 15:06)</a>:</h4>
<p>can help with PR/issue triage if needed</p>



<a name="214495436"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214495436" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> ThibsG <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214495436">(Oct 25 2020 at 15:34)</a>:</h4>
<p>I'm gonna help too (only if i'm sure about what i'm saying <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span> )</p>



<a name="214502733"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214502733" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> ThibsG <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214502733">(Oct 25 2020 at 17:54)</a>:</h4>
<p>btw, do we need special permissions to set labels?<br>
<a href="https://github.com/rust-lang/rust-clippy/issues/5827">https://github.com/rust-lang/rust-clippy/issues/5827</a></p>



<a name="214510758"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214510758" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214510758">(Oct 25 2020 at 20:36)</a>:</h4>
<p>After <a href="https://github.com/rust-lang/rust-clippy/issues/6225">clippy#6225</a> is merged everyone should be able to modify any label (except <code>hacktoberfest</code>) with @rustbot.</p>



<a name="214511004"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/214511004" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#214511004">(Oct 25 2020 at 20:42)</a>:</h4>
<p>I set the labels in <a href="https://github.com/rust-lang/rust-clippy/issues/5827">clippy#5827</a> by hand. FYI: GitHub lets you set message templates, which can be accessed with <code>Ctrl-.</code>-&gt;<code>Ctrl-[1-9]</code>: <a href="https://github.com/settings/replies">https://github.com/settings/replies</a> This may be interesting for rustbot labeling for often used labels.</p>



<a name="215831849"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/215831849" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> flip1995 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#215831849">(Nov 06 2020 at 11:11)</a>:</h4>
<p><a href="/user_uploads/4715/VnMBR8m4hwCV3cEEuNtiH_-Y/image.png">image.png</a> </p>
<div class="message_inline_image"><a href="/user_uploads/4715/VnMBR8m4hwCV3cEEuNtiH_-Y/image.png" title="image.png"><img src="/user_uploads/4715/VnMBR8m4hwCV3cEEuNtiH_-Y/image.png"></a></div><p>Now even GitHub complains about my notifications from Clippy, I didn't get to (yet) . <span aria-label="smiley" class="emoji emoji-1f603" role="img" title="smiley">:smiley:</span></p>



<a name="215895219"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257328-clippy/topic/Sorry%20for%20being%20absent/near/215895219" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mati865 <a href="https://rust-lang.github.io/zulip_archive/stream/257328-clippy/topic/Sorry.20for.20being.20absent.html#215895219">(Nov 06 2020 at 19:48)</a>:</h4>
<p>Noticed it as well even though I cleanup notifications every day.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>